Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote: > * Joe Perches [2017-02-21 10:47:31 -0800]: > > > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > > > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > > > > > > > The first declaration fit nicely on a single line. > > > > T

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Joe Perches [2017-02-21 10:47:31 -0800]: On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > The first declaration fit nicely on a single line. > The second one indeed has a few spaces instead of TABs in the > continuation line. But

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Joe Perches
On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > * Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: > > > The first declaration fit nicely on a single line. > > The second one indeed has a few spaces instead of TABs in the > > continuation line. But that can be fixed easily, without movi

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Geert Uytterhoeven [2017-02-21 15:22:10 +0100]: The first declaration fit nicely on a single line. The second one indeed has a few spaces instead of TABs in the continuation line. But that can be fixed easily, without moving the first parameter to a continuation line. What would the propose

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Geert Uytterhoeven
Hi Matthew, On Tue, Feb 21, 2017 at 3:12 PM, Matthew Giassa wrote: >>> drivers/staging/ks7010/ks_wlan_ioctl.h | 80 >>> +- >>> 1 file changed, 41 insertions(+), 39 deletions(-) >>> >>> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h >>> b/drivers/staging/ks701

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Geert Uytterhoeven [2017-02-21 08:59:18 +0100]: Hi Geert, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa wrote: Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---" and the diffstat below. Thank you. Some additional style chan

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Geert Uytterhoeven
Hi Matthew, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa wrote: > Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---" and the diffstat below. > Some additional style changes to appease checkpatch. Which additional style changes? > --

[PATCH] staging/ks7010: formatting updates.

2017-02-20 Thread Matthew Giassa
Please pardon the earlier e-mail which was missing the changelog text. Wrapping complex macros with parentheses to remove checkpatch errors. Some additional style changes to appease checkpatch. --- drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +- 1 file changed, 41