Re: [PATCH] staging/lustre: Unbreak ll_prep_inode iget result check

2016-03-02 Thread Greg KH
On Wed, Mar 02, 2016 at 08:25:39AM -0500, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests") > managed to break one of the converted checks by losing a dereference > causing the condition to be wrong and

[PATCH] staging/lustre: Unbreak ll_prep_inode iget result check

2016-03-02 Thread green
From: Oleg Drokin commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests") managed to break one of the converted checks by losing a dereference causing the condition to be wrong and hence leading to a crash later on in case of actual error. IS_ERR_OR_NULL(*inode)