Re: [PATCH] staging/rtl8188eu: fix line length exceeds 100 columns

2020-10-27 Thread Dan Carpenter
On Tue, Oct 20, 2020 at 08:17:48AM -0700, Elena Afanasova wrote: > Reported by checkpatch.pl > If I were trying to clean up this driver I would probably take a different approach. Just send a patch that introduces line breaks for RT_TRACE() printks. The RT_TRACE() printks are super ugly, and if

Re: [Outreachy kernel] [PATCH] staging/rtl8188eu: fix line length exceeds 100 columns

2020-10-20 Thread Vaishali Thakkar
On Tue, Oct 20, 2020 at 8:56 PM Elena Afanasova wrote: > > Reported by checkpatch.pl Hi Elena, Thanks for your patches. Your commit log should mention why are you doing certain changes. Above commit log doesn't give reviewer/maintainer an idea about what are you fixing and why that change is

[PATCH] staging/rtl8188eu: fix line length exceeds 100 columns

2020-10-20 Thread Elena Afanasova
Reported by checkpatch.pl Signed-off-by: Elena Afanasova --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 118 +++--- 1 file changed, 81 insertions(+), 37 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c index