Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-11 Thread Christoph Hellwig
On Wed, Sep 11, 2013 at 10:51:50AM +0800, Peng Tao wrote: I'm not fighting against removing the piece of code. But if there is a strong reason to keep the functionality, we need to find a way to implement it. The convenience of using environment variables is that job scheduler can set the

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-11 Thread Dilger, Andreas
On 2013/09/11 10:29 AM, Christoph Hellwig h...@infradead.org wrote: Talking about nasty code, the whole linux-curproc.c is highly questionable: - cfs_curproc_groups_nr: unused and should be removed This is already removed in the upstream Lustre code, it just hasn't made it into the

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Heiko Carstens
On Sun, Sep 08, 2013 at 07:31:18PM -0700, Guenter Roeck wrote: On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote: On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote: mips

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Christoph Hellwig
On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote: Can't we just export the functions for those arches? Surely lutre isn't the first/only driver that needs this? Lustre is. These are core mm helpers, and lustre uses them to reimplement another core VM function. It then uses

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Ramkumar Ramachandra
Greg Kroah-Hartman wrote: What do you mean by this? What initial cost? You should be able to cross-compile almost all arches on your desktop machine today with the compilers we have on kernel.org. If I can get them set up and working, they can't be that hard for anyone else :) Won't you

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote: On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote: mips allmodconfig fails with ERROR: copy_from_user_page

[PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
mips allmodconfig fails with ERROR: copy_from_user_page [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! which is due to LUSTRE using copy_from_user_page which is not exported by any architecture. Unfortunately, LUSTRE can only be built as module, so there is no easy fix. MIPS, SH,

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Ramkumar Ramachandra
Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote: mips allmodconfig fails with ERROR: copy_from_user_page [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! which is due to LUSTRE using copy_from_user_page which is not exported by any

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Greg Kroah-Hartman
On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote: mips allmodconfig fails with ERROR: copy_from_user_page [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! which is due to LUSTRE using copy_from_user_page which is not exported by any architecture. Any, or just

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Greg Kroah-Hartman
On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote: On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote: Can't we just export the functions for those arches? Surely lutre isn't the first/only driver that needs this? Lustre is. These are core mm helpers, and

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Ramkumar Ramachandra
Greg Kroah-Hartman wrote: How will the hardware industry be driven otherwise? I have no idea what you are referring to here, please explain. For stability, hardware needs to be present. When I started out a couple of days ago, I blamed my monitor for the data corruption: it's one extra point

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On Tue, Sep 10, 2013 at 10:49:05AM +0200, Geert Uytterhoeven wrote: On Mon, Sep 9, 2013 at 10:06 PM, Guenter Roeck li...@roeck-us.net wrote: [*] Why does m68k allmodconfig still succeed on kissb??? It does fail for me, as m68k's copy_from_user_page() calls flush_icache_user_range(),

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote: mips allmodconfig fails with ERROR: copy_from_user_page [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! which is due to LUSTRE using copy_from_user_page which is not

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Greg Kroah-Hartman
On Mon, Sep 09, 2013 at 08:08:28AM +0530, Ramkumar Ramachandra wrote: Greg Kroah-Hartman wrote: What do you mean by this? What initial cost? You should be able to cross-compile almost all arches on your desktop machine today with the compilers we have on kernel.org. If I can get them set

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On 09/08/2013 07:55 PM, Ramkumar Ramachandra wrote: Greg Kroah-Hartman wrote: How will the hardware industry be driven otherwise? I have no idea what you are referring to here, please explain. For stability, hardware needs to be present. When I started out a couple of days ago, I blamed my

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Peng Tao
On Mon, Sep 9, 2013 at 1:01 PM, Heiko Carstens heiko.carst...@de.ibm.com wrote: On Sun, Sep 08, 2013 at 07:31:18PM -0700, Guenter Roeck wrote: On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote: On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote: On 09/08/2013 06:59 PM, Greg

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Geert Uytterhoeven
On Tue, Sep 10, 2013 at 6:44 PM, Guenter Roeck li...@roeck-us.net wrote: I tried with 2.6.3 from crosstool, and it succeeded, too. Do such old versions of gcc still exist ? Just kidding :) Turns out cfs_access_process_vm() is called with write=0 only. Gcc 2.6.3 optimizes away the write != 0

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On Mon, Sep 09, 2013 at 09:11:25PM +0200, Geert Uytterhoeven wrote: On Mon, Sep 9, 2013 at 7:22 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote: On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote: On

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote: On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote: Can't we just export the functions for those arches? Surely lutre isn't the

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Geert Uytterhoeven
On Mon, Sep 9, 2013 at 7:22 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote: On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote: On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote: On Sun,

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Peng Tao
On Tue, Sep 10, 2013 at 4:49 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Sep 9, 2013 at 10:06 PM, Guenter Roeck li...@roeck-us.net wrote: [*] Why does m68k allmodconfig still succeed on kissb??? It does fail for me, as m68k's copy_from_user_page() calls

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Peng Tao
On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig h...@infradead.org wrote: On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote: The problem is access_process_vm() is not exported since certain version of kernel including the latest. According to Christoph in the other mail,

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Guenter Roeck
On Wed, Sep 11, 2013 at 10:25:57AM +0800, Peng Tao wrote: On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig h...@infradead.org wrote: On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote: The problem is access_process_vm() is not exported since certain version of kernel including the

Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA

2013-09-10 Thread Peng Tao
On Wed, Sep 11, 2013 at 10:30 AM, Guenter Roeck li...@roeck-us.net wrote: On Wed, Sep 11, 2013 at 10:25:57AM +0800, Peng Tao wrote: On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig h...@infradead.org wrote: On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote: The problem is