Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> Anyway, those are some ideas. Thanks for your comments Dan, Addressed your comments and resubmitted in /net/wireless Thanks Srini ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverde

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> It would be more common just to check for CONFIG_PURELIFI_AP in the source > file(s) instead of adding a synonym for it. Thanks for your comments Randy, Addressed your comments and resubmitted in /net/wireless Thanks Srini ___ devel mailing list de

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> There's nothing in the "how to submit a driver/patch" documentation that > mentions that it has to go through staging first, does it? If so, that > needs to be changed... Thanks for the feedback Greg, Addressed your comments and resubmitted in /net/wireless Regards Srini ___

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Dan Carpenter
On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > + > +#include > +#include > + > +#include "def.h" > +#include "chip.h" > +#include "mac.h" > +#include "usb.h" > +#include "log.h" > + > +void purelifi_chip_init(struct purelifi_chip *chip, > + struct ieee80211

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Randy Dunlap
Hi, On 9/24/20 8:18 AM, Srinivasan Raju wrote: > diff --git a/drivers/staging/purelifi/Kconfig > b/drivers/staging/purelifi/Kconfig > new file mode 100644 > index ..db24bdf884a3 > --- /dev/null > +++ b/drivers/staging/purelifi/Kconfig > @@ -0,0 +1,42 @@ > +config WLAN_VENDOR_PURELIFI

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Greg Kroah-Hartman
On Thu, Sep 24, 2020 at 05:24:14PM +, Srinivasan Raju wrote: > > >> --- /dev/null > >> +++ b/drivers/staging/purelifi/TODO > >> @@ -0,0 +1,5 @@ > >> +TODO: > >> + - checkpatch.pl cleanups > >> + > >> +Please send any patches or complaints about this driver to pureLiFi Ltd > >> + > > >Why

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Srinivasan Raju
>> --- /dev/null >> +++ b/drivers/staging/purelifi/TODO >> @@ -0,0 +1,5 @@ >> +TODO: >> + - checkpatch.pl cleanups >> + >> +Please send any patches or complaints about this driver to pureLiFi Ltd >> + >Why not just do these fixups on your own right now and submit it to the >"real" part of th

[PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Srinivasan Raju
From: Srini This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices, which provide lightweight, highspeed secure and fully networked wireless communications via light. This driver implementation has been based on the zd1211rw driver Driver is based on 802.11 softMAC

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Greg Kroah-Hartman
On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > +++ b/drivers/staging/purelifi/chip.c > @@ -0,0 +1,184 @@ > +// SPDX-License-Identifier: GNU General Public License v2.0 or later That's not a valid SPDX identifier :) > +/* Copyright (c) 2015-2020 pureLiFi Ltd > + * All rights

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Greg Kroah-Hartman
On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > +PUREILIFI USB DRIVER > +M: pureLiFi Ltd I need a real person here, having aliases as maintainers results in a lack of accountability :( > --- /dev/null > +++ b/drivers/staging/purelifi/TODO > @@ -0,0 +1,5 @@ > +TODO: > + -