Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-07-10 Thread Greg Kroah-Hartman
On Tue, Jul 07, 2020 at 08:43:30PM -0700, John Stultz wrote: > On Fri, Jul 3, 2020 at 12:03 AM Greg Kroah-Hartman > wrote: > > On Tue, Apr 21, 2020 at 10:05:44AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > > > > The dmabuf heaps have been

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-07-07 Thread John Stultz
On Fri, Jul 3, 2020 at 12:03 AM Greg Kroah-Hartman wrote: > On Tue, Apr 21, 2020 at 10:05:44AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > > > The dmabuf heaps have been in an official kernel now for all of three > > > weeks. So yea, we can

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-07-03 Thread Greg Kroah-Hartman
On Tue, Apr 21, 2020 at 10:05:44AM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > > On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner > > wrote: > > > On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > > > > On Tue, Apr 14,

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-21 Thread Greg Kroah-Hartman
On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner > wrote: > > On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > > > But I do think we can mark

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-20 Thread John Stultz
On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner wrote: > On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > > But I do think we can mark it as deprecated and let folks know that > > > around the end of the

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-20 Thread Christian Brauner
On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > > > Only sync the

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-20 Thread Christoph Hellwig
On Fri, Apr 17, 2020 at 05:00:13PM +0200, Daniel Vetter wrote: > > No one ever notices "depreciated" things, they only notice if the code > > is no longer there :) > > > > So I'm all for just deleting it and seeing who even notices... > > +1 on just deleting ion and watching if anyone notices.

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-17 Thread Daniel Vetter
On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > > > Only sync the

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-16 Thread Ørjan Eide
On Thu, Apr 16, 2020 at 12:49:56PM +0300, Dan Carpenter wrote: > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > @@ -238,6 +242,10 @@ static void ion_unmap_dma_buf(struct > > dma_buf_attachment *attachment, > > struct sg_table *table, > >

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-16 Thread Dan Carpenter
Great! Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-16 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman > wrote: > > > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > > is actually mapped on

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-16 Thread Dan Carpenter
On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > @@ -238,6 +242,10 @@ static void ion_unmap_dma_buf(struct dma_buf_attachment > *attachment, > struct sg_table *table, > enum dma_data_direction direction) > { > + struct

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread John Stultz
On Tue, Apr 14, 2020 at 9:11 AM Ørjan Eide wrote: > > On Tue, Apr 14, 2020 at 04:28:10PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, �rjan Eide wrote: > > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > > is actually mapped on the

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread John Stultz
On Tue, Apr 14, 2020 at 7:28 AM Greg Kroah-Hartman wrote: > > On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > is actually mapped on the device. > > > > dma-bufs may be synced at any time. It can be reached

[PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread Ørjan Eide
Only sync the sg-list of an Ion dma-buf attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be reached from user space via DMA_BUF_IOCTL_SYNC, so there are no guarantees from callers on when syncs may be attempted, and

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread Ørjan Eide
On Tue, Apr 14, 2020 at 04:28:10PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 14, 2020 at 04:18:47PM +0200, �rjan Eide wrote: > > Only sync the sg-list of an Ion dma-buf attachment when the attachment > > is actually mapped on the device. > > > > dma-bufs may be synced at any time. It can

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2020 at 04:18:47PM +0200, Ørjan Eide wrote: > Only sync the sg-list of an Ion dma-buf attachment when the attachment > is actually mapped on the device. > > dma-bufs may be synced at any time. It can be reached from user space > via DMA_BUF_IOCTL_SYNC, so there are no guarantees

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread Greg Kroah-Hartman
On Tue, Apr 14, 2020 at 03:46:27PM +0200, Ørjan Eide wrote: > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any

[PATCH] staging: android: ion: Skip sync if not mapped

2020-04-14 Thread Ørjan Eide
Only sync the sg-list of an Ion dma-buf attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be reached from user space via DMA_BUF_IOCTL_SYNC, so there are no guarantees from callers on when syncs may be attempted, and