Re: [PATCH] staging: comedi: cb_pcidas: reinstate delay removed from trimpot setting

2020-11-06 Thread Greg Kroah-Hartman
On Wed, Nov 04, 2020 at 10:49:18AM +, Ian Abbott wrote: > On 02/11/2020 11:16, Ian Abbott wrote: > > On 02/11/2020 10:25, Ian Abbott wrote: > > > On 29/10/2020 14:18, Ian Abbott wrote: > > > > Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor > > > > write_calibration_bitstream()")

Re: [PATCH] staging: comedi: cb_pcidas: reinstate delay removed from trimpot setting

2020-11-04 Thread Ian Abbott
On 02/11/2020 11:16, Ian Abbott wrote: On 02/11/2020 10:25, Ian Abbott wrote: On 29/10/2020 14:18, Ian Abbott wrote: Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor write_calibration_bitstream()") inadvertently removed one of the `udelay(1)` calls when writing to the calibration

Re: [PATCH] staging: comedi: cb_pcidas: reinstate delay removed from trimpot setting

2020-11-02 Thread Ian Abbott
On 02/11/2020 10:25, Ian Abbott wrote: On 29/10/2020 14:18, Ian Abbott wrote: Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor write_calibration_bitstream()") inadvertently removed one of the `udelay(1)` calls when writing to the calibration register in `cb_pcidas_calib_write()`. 

Re: [PATCH] staging: comedi: cb_pcidas: reinstate delay removed from trimpot setting

2020-11-02 Thread Ian Abbott
On 29/10/2020 14:18, Ian Abbott wrote: Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor write_calibration_bitstream()") inadvertently removed one of the `udelay(1)` calls when writing to the calibration register in `cb_pcidas_calib_write()`. Reinstate the delay. It may seem strange

[PATCH] staging: comedi: cb_pcidas: reinstate delay removed from trimpot setting

2020-10-29 Thread Ian Abbott
Commit eddd2a4c675c ("staging: comedi: cb_pcidas: refactor write_calibration_bitstream()") inadvertently removed one of the `udelay(1)` calls when writing to the calibration register in `cb_pcidas_calib_write()`. Reinstate the delay. It may seem strange that the delay is placed before the