Re: [PATCH] staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data

2014-03-31 Thread Ian Abbott
On 2014-03-31 15:57, Bernd Porr wrote: Indeed! That had been unnoticed for about 8 years! Well done Harley. /Bernd Actually, This particular bug has only been around since July 2013, appearing in the 3.12 kernel: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a998

Re: [PATCH] staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data

2014-03-31 Thread Bernd Porr
Indeed! That had been unnoticed for about 8 years! Well done Harley. /Bernd Ian Abbott wrote: [Sorry for the repeated email. One of the addresses I was replying to was corrupted.] On 2014-03-28 16:20, H Hartley Sweeten wrote: In usbdux_ao_cmd(), the channels for the command are transfered f

Re: [PATCH] staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data

2014-03-31 Thread Ian Abbott
[Sorry for the repeated email. One of the addresses I was replying to was corrupted.] On 2014-03-28 16:20, H Hartley Sweeten wrote: In usbdux_ao_cmd(), the channels for the command are transfered from the cmd->chanlist and stored in the private data 'ao_chanlist'. The channel numbers are bit-s

[PATCH] staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data

2014-03-28 Thread H Hartley Sweeten
In usbdux_ao_cmd(), the channels for the command are transfered from the cmd->chanlist and stored in the private data 'ao_chanlist'. The channel numbers are bit-shifted when stored so that they become the "command" that is transfered to the device. The channel to command conversion results in the '