[PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-06 Thread Daeseok Youn
Null checks for tty, un and ch are already done by caller, so replace parameter "tty" with "ch" and "un". And also use a pointer for returning new bytes_available instead of return variable. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 29 +++-- 1 file

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread Greg KH
On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: > Null checks for tty, un and ch are already done by caller, > so replace parameter "tty" with "ch" and "un". > > And also use a pointer for returning new bytes_available instead of > return variable. Why make that change? It's nicer

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread DaeSeok Youn
Hi, 2014-07-10 4:02 GMT+09:00 Greg KH : > On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: >> Null checks for tty, un and ch are already done by caller, >> so replace parameter "tty" with "ch" and "un". >> >> And also use a pointer for returning new bytes_available instead of >> retur