Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-11 Thread Konrad Zapalowicz
On 08/11, Greg KH wrote: > On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote: > > On 08/10, Greg KH wrote: > > > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > > > > This commit binds global variables of dgnc driver in a structure so > > > > that it is logicall

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Greg KH
On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote: > On 08/10, Greg KH wrote: > > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > > > This commit binds global variables of dgnc driver in a structure so > > > that it is logically consistent. The structure is acce

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Konrad Zapalowicz
On 08/10, Greg KH wrote: > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > > This commit binds global variables of dgnc driver in a structure so > > that it is logically consistent. The structure is accessed via getter > > function and as a result the externing of globals is re

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-10 Thread Greg KH
On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > This commit binds global variables of dgnc driver in a structure so > that it is logically consistent. The structure is accessed via getter > function and as a result the externing of globals is removed. The names > of the variabl

[PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-09 Thread Konrad Zapalowicz
This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed. The names of the variables are also changed to be more eye friendly. Signed-off-by: Konrad Zapalow