[PATCH] staging: dgnc: check return value of kzalloc

2015-05-29 Thread Gujulan Elango, Hari Prasath (H.)
check return value of kzalloc and return error if it fails. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com --- drivers/staging/dgnc/dgnc_tty.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index

Re: [PATCH] staging: dgnc: check return value of kzalloc

2015-05-29 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, May 28, 2015 at 04:32:30PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 01:23:57PM +, Gujulan Elango, Hari Prasath (H.) wrote: Check the return value of kzalloc return error if it fails. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com ---

Re: [PATCH] staging: dgnc: check return value of kzalloc

2015-05-29 Thread Dan Carpenter
On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.) wrote: check return value of kzalloc and return error if it fails. There is a problem with your patch. See if you can spot it. Also can you add to the changelog what are the user visible effects of not checking for

Re: [PATCH] staging: dgnc: check return value of kzalloc

2015-05-29 Thread Gujulan Elango, Hari Prasath (H.)
On Fri, May 29, 2015 at 01:52:28PM +0300, Dan Carpenter wrote: On Fri, May 29, 2015 at 10:06:48AM +, Gujulan Elango, Hari Prasath (H.) wrote: On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote: On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.)

Re: [PATCH] staging: dgnc: check return value of kzalloc

2015-05-29 Thread Dan Carpenter
On Fri, May 29, 2015 at 10:06:48AM +, Gujulan Elango, Hari Prasath (H.) wrote: On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote: On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.) wrote: check return value of kzalloc and return error if it fails.

Re: [PATCH] staging: dgnc: check return value of kzalloc

2015-05-29 Thread Gujulan Elango, Hari Prasath (H.)
On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote: On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.) wrote: check return value of kzalloc and return error if it fails. There is a problem with your patch. See if you can spot it. Also can you add

[PATCH] staging: dgnc: check return value of kzalloc

2015-05-28 Thread Gujulan Elango, Hari Prasath (H.)
Check the return value of kzalloc return error if it fails. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com --- drivers/staging/dgnc/dgnc_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index

Re: [PATCH] staging: dgnc: check return value of kzalloc

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 01:23:57PM +, Gujulan Elango, Hari Prasath (H.) wrote: Check the return value of kzalloc return error if it fails. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com --- drivers/staging/dgnc/dgnc_driver.c | 2 ++ 1 file changed, 2 insertions(+)