Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Joe Perches
On Tue, 2013-09-10 at 21:41 -0700, Kees Cook wrote: Make sure that format strings cannot leak into printk() calls from the msgbuf string. printf(string); vs printf(%s, string); How does this help? ___ devel mailing list

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Kees Cook
On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches j...@perches.com wrote: On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote: In the former case, format

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Kees Cook
On Wed, Sep 11, 2013 at 12:22 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Sep 11, 2013 at 11:19:11AM -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote: In the former

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-11 Thread Joe Perches
On Wed, 2013-09-11 at 12:25 -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches j...@perches.com wrote: On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote: On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 10, 2013 at 10:19:17PM

[PATCH] staging: dgnc: fix potential format string flaw

2013-09-10 Thread Kees Cook
Make sure that format strings cannot leak into printk() calls from the msgbuf string. Signed-off-by: Kees Cook keesc...@chromium.org --- drivers/staging/dgnc/dgnc_driver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c

Re: [PATCH] staging: dgnc: fix potential format string flaw

2013-09-10 Thread Kees Cook
On Tue, Sep 10, 2013 at 10:00 PM, Joe Perches j...@perches.com wrote: On Tue, 2013-09-10 at 21:41 -0700, Kees Cook wrote: Make sure that format strings cannot leak into printk() calls from the msgbuf string. printf(string); vs printf(%s, string); How does this help? In