On Wed, Aug 21, 2013 at 01:27:15PM -0400, Lidza Louina wrote: > This patch fixes the error: "foo* bar" should be "foo *bar". >
I have a nit pick about this changelog. It's not something to resend over, of course, but for future patches. The word "fix" should only be used for bugfixes. The word "clean up" is the opposite and should not be used for changes which affect how the code works. It's pretty much kernel standard to separate fixes and cleanups as two different things. https://www.google.com/search?q=fix+clean+ups+linux+kernel A "syntax error" means something that breaks the compile. So I was expecting a fix for the compile. A better subject would be: "[PATCH] staging: dgnc: tty.c: clean up pointer white space" regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
