Re: [PATCH] staging: erofs: a few minor style fixes found using checkpatch

2019-07-16 Thread Gao Xiang
Hi Karen, On 2019/7/17 ??2:56, Karen Palacio wrote: > Hello, thanks for the fast reply.?? > > />NACK, all linux filesystems use Opt_xxx. EROFS should obey this practice. > /I wasn't aware of that convention, my apologies. > > Should I fix that, keep the other changes and resend as v2, or >

Re: [PATCH] staging: erofs: a few minor style fixes found using checkpatch

2019-07-16 Thread Gao Xiang
On 2019/7/17 12:35, Karen Palacio wrote: > Fix camel case use in variable names, > Fix multiple assignments done in a single line, > Fix end of line containing '('. One type one patch... > > Signed-off-by: Karen Palacio > --- > drivers/staging/erofs/super.c | 55 >

[PATCH] staging: erofs: a few minor style fixes found using checkpatch

2019-07-16 Thread Karen Palacio
Fix camel case use in variable names, Fix multiple assignments done in a single line, Fix end of line containing '('. Signed-off-by: Karen Palacio --- drivers/staging/erofs/super.c | 55 ++- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git