Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
Welp, looks like I didn't test debug configs properly. Allow me 1-2 days to work on fixing it for v2. Thanks in advance. On Thu, Sep 19, 2019 at 6:31 AM kbuild test robot wrote: > > Hi Park, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] >

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread kbuild test robot
Hi Park, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190917] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread kbuild test robot
Hi Park, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190917] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Valdis Klētnieks
On Thu, 19 Sep 2019 05:31:21 +0900, Ju Hyung Park said: > We should probably ask Valdis on what happened there. > > Even the old exFAT v1.2.24 from Galaxy S7 is using "either version 2 > of the License, or (at your option) any later version". > You can go check it yourself by searching "G930F"

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
On Thu, Sep 19, 2019 at 5:26 AM Greg KH wrote: > That differs from the original exfat code, so something is odd here. I > need some sort of clarification from Samsung as to when they changed the > license in order to be able to relicense these files. We should probably ask Valdis on what

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 05:22:03AM +0900, Ju Hyung Park wrote: > Hi Greg, > > On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > > That's a lot of rewriting :( > > > > How about at least keeping the file names the same to make it easier to > > see what happened here? > > > > Then send a follow-on

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
Hi Greg, On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > That's a lot of rewriting :( > > How about at least keeping the file names the same to make it easier to > see what happened here? > > Then send a follow-on patch that just does the rename? That's still not quite useful tbh, lemme bring

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > --- a/drivers/staging/exfat/exfat.h > +++ b/drivers/staging/exfat/exfat.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +// SPDX-License-Identifier: GPL-2.0-or-later You just changed the license of this file. Are

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Greg KH
On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > The new sdFAT driver base brings many improvements to the table. > Quoting Namjae Jeon: > > == > 1. sdfat has been refactored to improve compatibility, readability