Functions port_vlans_add() and port_vlans_del() could,
in theory, return an uninitialized variable. Fix this
by initializing the variable in question at declaration.

Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
---
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c 
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index ecdd3d8..c1616c3 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -717,7 +717,7 @@ static int port_vlans_add(struct net_device *netdev,
                          struct switchdev_trans *trans)
 {
        struct ethsw_port_priv *port_priv = netdev_priv(netdev);
-       int vid, err;
+       int vid, err = 0;
 
        if (netif_is_bridge_master(vlan->obj.orig_dev))
                return -EOPNOTSUPP;
@@ -872,7 +872,7 @@ static int port_vlans_del(struct net_device *netdev,
                          const struct switchdev_obj_port_vlan *vlan)
 {
        struct ethsw_port_priv *port_priv = netdev_priv(netdev);
-       int vid, err;
+       int vid, err = 0;
 
        if (netif_is_bridge_master(vlan->obj.orig_dev))
                return -EOPNOTSUPP;
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to