Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

2015-05-29 Thread Greg KH
On Thu, May 28, 2015 at 11:16:27PM +0200, Xavier Roche wrote: Hi Greg mailing-list members, On Thu, 28 May 2015, Greg KH wrote: In the future, always use scripts/get_maintainer.pl to determine who to send patches to please. Sorry, I did use the get_maintainer.pl script, but I did not

Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

2015-05-28 Thread Xavier Roche
Hi Greg mailing-list members, On Thu, 28 May 2015, Greg KH wrote: In the future, always use scripts/get_maintainer.pl to determine who to send patches to please. Sorry, I did use the get_maintainer.pl script, but I did not want to bother too many people, and I only picked Marek in CC: (I

Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

2015-05-28 Thread Greg KH
On Thu, May 28, 2015 at 05:24:56PM +0200, Xavier Roche wrote: Local functions not used in other modules should be static, not extern. (patch checked against linux-next and staging) This line shouldn't be here, it should just be implied :) Signed-off-by: Xavier Roche ro...@httrack.com ---

[PATCH] staging: ft1000: warning removal: extern functions to static ones

2015-05-28 Thread Xavier Roche
Local functions not used in other modules should be static, not extern. (patch checked against linux-next and staging) Signed-off-by: Xavier Roche ro...@httrack.com --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++--- 1 file changed, 12 insertions(+), 12