Re: [PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-19 Thread Prakash Dubey
On Fri, Feb 19, 2021 at 02:52:21PM +0300, Dan Carpenter wrote: > On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote: > > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > > > I was unable to align it right below the opening parenthesis, just by > > > using > > > tabs.

Re: [PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-19 Thread Dan Carpenter
On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote: > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > > I was unable to align it right below the opening parenthesis, just by using > > tabs. And when I did that with spaces, the checkpatch yelled at me for > > using

Re: [PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > I was unable to align it right below the opening parenthesis, just by using > tabs. And when I did that with spaces, the checkpatch yelled at me for > using spaces. Any suggestions how to do this without using spaces? I am >

Re: [PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-19 Thread Greg KH
On Thu, Feb 18, 2021 at 03:58:51PM +0530, Prakash Dubey wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Prakash Dubey > --- > drivers/staging/fwserial/fwserial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-18 Thread Prakash Dubey
This patch fixes the following checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: Prakash Dubey --- drivers/staging/fwserial/fwserial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fwserial/fwserial.c