AW: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl()

2021-03-09 Thread Walter Harms
rnel-janit...@vger.kernel.org; John Joseph; Simon Que; Richard Yeh; Todd Poynor Betreff: Re: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl() On Fri, Jan 22, 2021 at 06:01:13PM +0300, Dan Carpenter wrote: > The "gasket_dev->num_page_tables" variable is an int but th

Re: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl()

2021-03-09 Thread Greg Kroah-Hartman
On Tue, Mar 09, 2021 at 04:57:59PM +, Walter Harms wrote: > why not mark it as "Deprecated" and remove it with the next version ? Maybe > soneone will wakeup ? We don't really have a "Deprecated" marking, we just delete them :) thanks, greg k-h

Re: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl()

2021-03-09 Thread Greg Kroah-Hartman
On Fri, Jan 22, 2021 at 06:01:13PM +0300, Dan Carpenter wrote: > The "gasket_dev->num_page_tables" variable is an int but this is copying > sizeof(u64). On 32 bit systems this would end up disclosing a kernel > pointer to user space, but on 64 bit it copies zeroes from a struct > hole. > >

[PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl()

2021-01-22 Thread Dan Carpenter
The "gasket_dev->num_page_tables" variable is an int but this is copying sizeof(u64). On 32 bit systems this would end up disclosing a kernel pointer to user space, but on 64 bit it copies zeroes from a struct hole. Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")