Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Greg Kroah-Hartman
On Wed, Nov 30, 2016 at 01:15:50PM -0600, Alex Elder wrote: > On 11/30/2016 12:32 PM, Dan Carpenter wrote: > > On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: > >> Honestly, for a kernel newbie it is difficult to manage. I received 2 > >> email that suggest > >> to use S_IRUGO. My

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Alex Elder
On 11/30/2016 12:32 PM, Dan Carpenter wrote: > On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: >> Honestly, for a kernel newbie it is difficult to manage. I received 2 >> email that suggest >> to use S_IRUGO. My original patch was with octal, based on checkpatch.pl >> advice. Go

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Dan Carpenter
On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: > Honestly, for a kernel newbie it is difficult to manage. I received 2 > email that suggest > to use S_IRUGO. My original patch was with octal, based on checkpatch.pl > advice. You've going to have to get used to conflicting advice

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-30 Thread Andrea Ghittino
On Wed, Nov 30, 2016 at 12:21 AM, Dan Carpenter wrote: > On Tue, Nov 29, 2016 at 03:59:46PM -0600, Alex Elder wrote: >> On 11/26/2016 03:50 PM, Andrea Ghittino wrote: >> > Fixes greybus user/groups permission style warnings >> > found by checkpatch.pl tool >> > >> > Signed-off-by: Andrea Ghittino

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-29 Thread Dan Carpenter
On Tue, Nov 29, 2016 at 03:59:46PM -0600, Alex Elder wrote: > On 11/26/2016 03:50 PM, Andrea Ghittino wrote: > > Fixes greybus user/groups permission style warnings > > found by checkpatch.pl tool > > > > Signed-off-by: Andrea Ghittino > > I don't understand why using 0444 would be preferred >

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-29 Thread Alex Elder
On 11/26/2016 03:50 PM, Andrea Ghittino wrote: > Fixes greybus user/groups permission style warnings > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino I don't understand why using 0444 would be preferred over S_IRUGO (for example). Do you know? Maybe the checkpatch.pl output sa

Re: [PATCH] staging: greybuis: fix permission style warnings

2016-11-26 Thread Bryan O'Donoghue
On Sat, 2016-11-26 at 22:50 +0100, Andrea Ghittino wrote: > Fixes greybus user/groups permission style warnings  > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino > --- > diff --git a/drivers/staging/greybus/camera.c > b/drivers/staging/greybus/camera.c > index 1c5b41a..4424f63 100

[PATCH] staging: greybuis: fix permission style warnings

2016-11-26 Thread Andrea Ghittino
Fixes greybus user/groups permission style warnings found by checkpatch.pl tool Signed-off-by: Andrea Ghittino --- diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index 1c5b41a..4424f63 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/c