Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Greg KH
On Thu, Jul 27, 2017 at 04:35:32PM +0300, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: > > Hi Dan, > > > > Understand the readability issue, but this patch seems readable. > > > > I would have probably merged the patch, but whatever... Ignoring long >

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Viresh Kumar
On 27-07-17, 08:37, Deb McLemore wrote: > Hi Dan, thanks. > > I'll look for another subsystem to help improve the quality and standards. Please don't do *top-posting*. > On 07/27/2017 08:35 AM, Dan Carpenter wrote: > > On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: > >> Hi Dan, >

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Deb McLemore
Hi Dan, thanks. I'll look for another subsystem to help improve the quality and standards. On 07/27/2017 08:35 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: >> Hi Dan, >> >> Understand the readability issue, but this patch seems readable. >> > > I

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Dan Carpenter
On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote: > Hi Dan, > > Understand the readability issue, but this patch seems readable. > I would have probably merged the patch, but whatever... Ignoring long lines in .h files is within normal bounds of "being special" for maintainers.

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Deb McLemore
Hi Dan, Understand the readability issue, but this patch seems readable. On 07/27/2017 08:16 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 08:10:35AM -0500, Deb McLemore wrote: >> Hi Viresh, >> >> So does greybus not follow the coding style from checkpatch.pl ? >> > > Sometimes people go

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Dan Carpenter
On Thu, Jul 27, 2017 at 08:10:35AM -0500, Deb McLemore wrote: > Hi Viresh, > > So does greybus not follow the coding style from checkpatch.pl ? > Sometimes people go over the 80 character limit if we think it's more readable. regards, dan carpenter

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-27 Thread Deb McLemore
Hi Viresh, So does greybus not follow the coding style from checkpatch.pl ? On 07/26/2017 10:32 PM, Viresh Kumar wrote: > On 26-07-17, 17:13, Deb McLemore wrote: >> checkpatch.pl line over 80 characters so fix the formatting >> for coding style compliance. >> >> Signed-off-by: Deb McLemore

Re: [PATCH] staging: greybus: Fix coding style issue for column width

2017-07-26 Thread Viresh Kumar
On 26-07-17, 17:13, Deb McLemore wrote: > checkpatch.pl line over 80 characters so fix the formatting > for coding style compliance. > > Signed-off-by: Deb McLemore > --- > drivers/staging/greybus/spilib.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[PATCH] staging: greybus: Fix coding style issue for column width

2017-07-26 Thread Deb McLemore
checkpatch.pl line over 80 characters so fix the formatting for coding style compliance. Signed-off-by: Deb McLemore --- drivers/staging/greybus/spilib.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/spilib.h