Re: [greybus-dev] [PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-27 Thread Alex Elder
On 1/25/20 6:14 AM, SAURAV GIREPUNJE wrote: > On 25/01/20 11:00 +0100, Johan Hovold wrote: >> On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: >>> fix uninitialized variables issue found using static code analysis tool >> >> Which tool is that? >> >>> (error) Uninitialized variable

Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-27 Thread Dan Carpenter
On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: > fix uninitialized variables issue found using static code analysis tool > > (error) Uninitialized variable: offset > (error) Uninitialized variable: size > These are false positives as Johan said. Don't change the code just to

Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-25 Thread SAURAV GIREPUNJE
On 25/01/20 11:00 +0100, Johan Hovold wrote: On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: fix uninitialized variables issue found using static code analysis tool Which tool is that? (error) Uninitialized variable: offset (error) Uninitialized variable: size Signed-off-b

Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-25 Thread Johan Hovold
On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: > fix uninitialized variables issue found using static code analysis tool Which tool is that? > (error) Uninitialized variable: offset > (error) Uninitialized variable: size > > Signed-off-by: Saurav Girepunje > --- > drivers/st

[PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-25 Thread Saurav Girepunje
fix uninitialized variables issue found using static code analysis tool (error) Uninitialized variable: offset (error) Uninitialized variable: size Signed-off-by: Saurav Girepunje --- drivers/staging/greybus/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/