Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Bryan O'Donoghue
On 08/02/17 14:16, Johan Hovold wrote: > On Wed, Feb 08, 2017 at 02:05:15PM +, Bryan O'Donoghue wrote: >> On 08/02/17 11:55, Johan Hovold wrote: >>> On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: On 08/02/17 09:43, Johan Hovold wrote: > On Tue, Feb 07, 2017 at

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 02:05:15PM +, Bryan O'Donoghue wrote: > On 08/02/17 11:55, Johan Hovold wrote: > > On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: > >> On 08/02/17 09:43, Johan Hovold wrote: > >>> On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: >

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Bryan O'Donoghue
On 08/02/17 11:55, Johan Hovold wrote: > On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: >> On 08/02/17 09:43, Johan Hovold wrote: >>> On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: On 07/02/17 14:19, Johan Hovold wrote: > On Mon, Jan 23, 2017 at

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Johan Hovold
On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote: > On 08/02/17 09:43, Johan Hovold wrote: > > On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: > >> On 07/02/17 14:19, Johan Hovold wrote: > >>> On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: >

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Bryan O'Donoghue
On 08/02/17 09:43, Johan Hovold wrote: > On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: >> On 07/02/17 14:19, Johan Hovold wrote: >>> On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: Add a struct timer_list to struct gb_operation and use that to implement

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-08 Thread Johan Hovold
On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote: > On 07/02/17 14:19, Johan Hovold wrote: > > On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: > >> Add a struct timer_list to struct gb_operation and use that to implement > >> generic operation timeouts. > >> > >> This

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-07 Thread Bryan O'Donoghue
On 07/02/17 14:19, Johan Hovold wrote: > On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: >> Add a struct timer_list to struct gb_operation and use that to implement >> generic operation timeouts. >> >> This simplifies the synchronous operation handling somewhat while also >>

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-02-07 Thread Johan Hovold
On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote: > Add a struct timer_list to struct gb_operation and use that to implement > generic operation timeouts. > > This simplifies the synchronous operation handling somewhat while also > providing a generic timeout mechanism that drivers

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-30 Thread Bryan O'Donoghue
On 27/01/17 09:55, Greg Kroah-Hartman wrote: > On Tue, Jan 24, 2017 at 03:57:54PM +, Bryan O'Donoghue wrote: >> On 24/01/17 15:09, Johan Hovold wrote: >> >>> Bryan, if you could consider my review feedback and respin your last >>> three patches on top of my timeout patch, I think we should be

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-27 Thread Greg Kroah-Hartman
On Tue, Jan 24, 2017 at 03:57:54PM +, Bryan O'Donoghue wrote: > On 24/01/17 15:09, Johan Hovold wrote: > > > Bryan, if you could consider my review feedback and respin your last > > three patches on top of my timeout patch, I think we should be good. > > Sure thing Bryan, can I get an

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-24 Thread Bryan O'Donoghue
On 24/01/17 15:09, Johan Hovold wrote: > Bryan, if you could consider my review feedback and respin your last > three patches on top of my timeout patch, I think we should be good. Sure thing ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-24 Thread Johan Hovold
On Mon, Jan 23, 2017 at 05:50:23PM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote: > > Have you run this through loopback without any # of in-flight operations > > constrained ? > > No, not yet as that would require also your changes to the loopback

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-23 Thread Johan Hovold
On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote: > On 23/01/17 15:13, Johan Hovold wrote: > > On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: > >> On 23/01/17 12:04, Johan Hovold wrote: > >> > >>> +static void gb_operation_timeout(unsigned long arg) > >>> +{ >

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-23 Thread Bryan O'Donoghue
On 23/01/17 15:13, Johan Hovold wrote: > On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: >> On 23/01/17 12:04, Johan Hovold wrote: >> >>> +static void gb_operation_timeout(unsigned long arg) >>> +{ >>> + struct gb_operation *operation = (void *)arg; >>> + >>> + if

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-23 Thread Johan Hovold
On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: > On 23/01/17 12:04, Johan Hovold wrote: > > > +static void gb_operation_timeout(unsigned long arg) > > +{ > > + struct gb_operation *operation = (void *)arg; > > + > > + if (gb_operation_result_set(operation, -ETIMEDOUT)) { >

Re: [PATCH] staging: greybus: operation: add generic timeout support

2017-01-23 Thread Bryan O'Donoghue
On 23/01/17 12:04, Johan Hovold wrote: > +static void gb_operation_timeout(unsigned long arg) > +{ > + struct gb_operation *operation = (void *)arg; > + > + if (gb_operation_result_set(operation, -ETIMEDOUT)) { > + /* > + * A stuck request message will be

[PATCH] staging: greybus: operation: add generic timeout support

2017-01-23 Thread Johan Hovold
Add a struct timer_list to struct gb_operation and use that to implement generic operation timeouts. This simplifies the synchronous operation handling somewhat while also providing a generic timeout mechanism that drivers can use for asynchronous operations. Signed-off-by: Johan Hovold