Re: [PATCH] staging: gs_fpgaboot: get bus width input

2020-07-22 Thread Greg KH
On Wed, Jul 22, 2020 at 12:11:22PM +0530, Rahul Gottipati wrote: > On Wed, Jul 22, 2020 at 08:32:54AM +0200, Greg KH wrote: > > On Wed, Jul 22, 2020 at 11:57:11AM +0530, Rahul Gottipati wrote: > > > On Tue, Jul 21, 2020 at 08:05:33PM +0200, Greg KH wrote: > > > > On Tue, Jul 21, 2020 at 11:32:03PM

Re: [PATCH] staging: gs_fpgaboot: get bus width input

2020-07-22 Thread Rahul Gottipati
On Wed, Jul 22, 2020 at 08:32:54AM +0200, Greg KH wrote: > On Wed, Jul 22, 2020 at 11:57:11AM +0530, Rahul Gottipati wrote: > > On Tue, Jul 21, 2020 at 08:05:33PM +0200, Greg KH wrote: > > > On Tue, Jul 21, 2020 at 11:32:03PM +0530, Rahul Gottipati wrote: > > > > This adds a module parameter to

Re: [PATCH] staging: gs_fpgaboot: get bus width input

2020-07-22 Thread Greg KH
On Wed, Jul 22, 2020 at 11:57:11AM +0530, Rahul Gottipati wrote: > On Tue, Jul 21, 2020 at 08:05:33PM +0200, Greg KH wrote: > > On Tue, Jul 21, 2020 at 11:32:03PM +0530, Rahul Gottipati wrote: > > > This adds a module parameter to get the program bus width as an > > > input rather than hardcoding

Re: [PATCH] staging: gs_fpgaboot: get bus width input

2020-07-22 Thread Rahul Gottipati
On Tue, Jul 21, 2020 at 08:05:33PM +0200, Greg KH wrote: > On Tue, Jul 21, 2020 at 11:32:03PM +0530, Rahul Gottipati wrote: > > This adds a module parameter to get the program bus width as an > > input rather than hardcoding it, and checks off a TODO item. > > Ick, no, module parameters are from

Re: [PATCH] staging: gs_fpgaboot: get bus width input

2020-07-21 Thread Greg KH
On Tue, Jul 21, 2020 at 11:32:03PM +0530, Rahul Gottipati wrote: > This adds a module parameter to get the program bus width as an > input rather than hardcoding it, and checks off a TODO item. Ick, no, module parameters are from the 1990's, please make this dynamic somehow. thanks, greg k-h

[PATCH] staging: gs_fpgaboot: get bus width input

2020-07-21 Thread Rahul Gottipati
This adds a module parameter to get the program bus width as an input rather than hardcoding it, and checks off a TODO item. Signed-off-by: Rahul Gottipati --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git