Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-29 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote: On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.) wrote: remove redundant code in this function by introducing a new retval

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-29 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, May 28, 2015 at 12:03:26PM -0700, insop.s...@gainspeed.com wrote: On Thu, May 28, 2015 at 09:50:23PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote: On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: On Thu, May

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-29 Thread Dan Carpenter
Originally when I was reviewing Hari's patch I had no idea you wrote this code so I was not as polite as I could have been. Sorry. On Thu, May 28, 2015 at 12:03:26PM -0700, insop.s...@gainspeed.com wrote: poorly thought out error messages. which one are you exactly refering? err =

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread insop.s...@gainspeed.com
On Thu, May 28, 2015 at 09:50:23PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote: On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.) wrote:

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote: On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.) wrote: remove redundant code in this function by introducing a new retval

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread insop.s...@gainspeed.com
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.) wrote: remove redundant code in this function by introducing a new retval variable. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com

[PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread Gujulan Elango, Hari Prasath (H.)
remove redundant code in this function by introducing a new retval variable. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.) wrote: remove redundant code in this function by introducing a new retval variable. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com No the original code is quite bad but this patch makes it worse.

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread Dan Carpenter
On Thu, May 28, 2015 at 10:19:40AM +, Gujulan Elango, Hari Prasath (H.) wrote: fimage = kmalloc(sizeof(struct fpgaimage), GFP_KERNEL); if (!fimage) @@ -298,44 +299,41 @@ static int gs_fpgaboot(void) err = gs_load_image(fimage, file); if (err) { goto

Re: [PATCH] staging: gs_fpgaboot: remove redundant code

2015-05-28 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.) wrote: remove redundant code in this function by introducing a new retval variable. Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com