Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Tong Zhang
On Fri, Feb 4, 2022 at 6:23 AM Greg Kroah-Hartman wrote: > > On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > > Loading the driver will always fail since > > xl_init_io() always returns -1. This driver is broken since 2014 and I > > doubt anyone is actually using it, we could either

Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Greg Kroah-Hartman
On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > gs_fpgaboot is currently useless since the board specific code is > removed in 06a3fab941da. Nit, commits should be printed out like this: 06a3fab941da ("staging: gs_fpgaboot: remove checks for CONFIG_B4860G100") > Loading the driver

Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Dan Carpenter
On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > gs_fpgaboot is currently useless since the board specific code is > removed in 06a3fab941da. Loading the driver will always fail since > xl_init_io() always returns -1. This driver is broken since 2014 and I > doubt anyone is actually

[PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-03 Thread Tong Zhang
gs_fpgaboot is currently useless since the board specific code is removed in 06a3fab941da. Loading the driver will always fail since xl_init_io() always returns -1. This driver is broken since 2014 and I doubt anyone is actually using it, we could either remove it or revert to the previous working