Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get

2019-10-18 Thread Jonathan Cameron
On Thu, 17 Oct 2019 12:56:33 + "Ardelean, Alexandru" wrote: > On Wed, 2019-10-16 at 22:25 +0800, Chuhong Yuan wrote: > > ad9834_probe misses a check for devm_clk_get and may cause problems. > > Add a check like what ad9832 does to fix it. > > > > This could also use a Fixes tag, but not

Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get

2019-10-17 Thread Ardelean, Alexandru
On Wed, 2019-10-16 at 22:25 +0800, Chuhong Yuan wrote: > ad9834_probe misses a check for devm_clk_get and may cause problems. > Add a check like what ad9832 does to fix it. > This could also use a Fixes tag, but not a big deal. Reviewed-by: Alexandru Ardelean > Signed-off-by: Chuhong Yuan >

Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get

2019-10-16 Thread Dan Carpenter
On Wed, Oct 16, 2019 at 10:25:40PM +0800, Chuhong Yuan wrote: > ad9834_probe misses a check for devm_clk_get and may cause problems. > Add a check like what ad9832 does to fix it. > > Signed-off-by: Chuhong Yuan Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter

[PATCH] staging: iio: ad9834: add a check for devm_clk_get

2019-10-16 Thread Chuhong Yuan
ad9834_probe misses a check for devm_clk_get and may cause problems. Add a check like what ad9832 does to fix it. Signed-off-by: Chuhong Yuan --- drivers/staging/iio/frequency/ad9834.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/iio/frequency/ad9834.c