Re: [PATCH] staging: iio: fix coding style

2014-06-14 Thread Jonathan Cameron
On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet This line has been removed by another patch in the meantime. --- Only tested by compilation. drivers/staging/iio/trigger/iio-tr

Re: [PATCH] staging: iio: fix coding style

2014-06-14 Thread Jonathan Cameron
On 13/06/14 06:56, Jimmy Picard wrote: This patch fixes coding style reported by checkpatch.pl that missing a blank line after declarations. Signed-off-by: Jimmy Picard Hmm. This is in the trivial enough to be marginally annoying category of basically noise. Normally I'd only take this as par

[PATCH] staging: iio: fix coding style

2014-06-12 Thread Jimmy Picard
This patch fixes coding style reported by checkpatch.pl that missing a blank line after declarations. Signed-off-by: Jimmy Picard --- drivers/staging/iio/iio_simple_dummy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_sim

Re: [PATCH] staging: iio: fix coding style

2014-06-12 Thread Greg Kroah-Hartman
On Thu, Jun 12, 2014 at 05:42:43PM +0800, Jimmy P wrote: > This patch fixes coding style errors reported by checkpatch.pl for > lines that was over 80 chars long. The macro value shoud be put in () as > well. > > Signed-off-by: Jimmy P We need a "real" or "full" name here for the signed-off-by:

[PATCH] staging: iio: fix coding style

2014-06-12 Thread Jimmy P
This patch fixes coding style errors reported by checkpatch.pl for lines that was over 80 chars long. The macro value shoud be put in () as well. Signed-off-by: Jimmy P --- drivers/staging/iio/frequency/ad5930.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/driv

Re: [PATCH] staging: iio: fix coding style

2014-04-14 Thread Jonathan Cameron
On April 14, 2014 2:59:32 PM GMT+01:00, "Joël Porquet" wrote: > > >On Saturday, April 12, 2014 06:28:07 PM Jonathan Cameron wrote: >> >> On 09/04/14 19:09, Joel Porquet wrote: >> > As suggested by checkpatch.pl, use dev_info() instead of >> > printk(KERN_INFO ...) to print message. >> > >> > Si

Re: [PATCH] staging: iio: fix coding style

2014-04-14 Thread Joël Porquet
On Saturday, April 12, 2014 06:28:07 PM Jonathan Cameron wrote: > > On 09/04/14 19:09, Joel Porquet wrote: > > As suggested by checkpatch.pl, use dev_info() instead of > > printk(KERN_INFO ...) to print message. > > > > Signed-off-by: Joel Porquet > > --- > > Only tested by compilation. > > d

Re: [PATCH] staging: iio: fix coding style

2014-04-14 Thread Dan O'Donovan
On Sat, 2014-04-12 at 18:28 +0100, Jonathan Cameron wrote: > On 09/04/14 19:09, Joel Porquet wrote: > > As suggested by checkpatch.pl, use dev_info() instead of > > printk(KERN_INFO ...) to print message. > > > > Signed-off-by: Joel Porquet > > --- > > Only tested by compilation. > > drivers/sta

Re: [PATCH] staging: iio: fix coding style

2014-04-12 Thread Jonathan Cameron
On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet --- Only tested by compilation. drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] staging: iio: fix coding style

2014-04-09 Thread Joel Porquet
As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet --- Only tested by compilation. drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/i