Re: [Outreachy kernel] Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-06 Thread SIMRAN SINGHAL
On Tue, Mar 6, 2018 at 2:33 AM, Julia Lawall wrote: > > > On Mon, 5 Mar 2018, Arushi Singhal wrote: > >> >> >> On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter >> wrote: >> On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: >> > Replace printk having a log level with the ap

Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-06 Thread Dan Carpenter
On Mon, Mar 05, 2018 at 11:41:43PM +0530, Arushi Singhal wrote: > On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter > wrote: > > > On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > > > Replace printk having a log level with the appropriate > > > net_*macro_ratelimited. > > > It's bett

Re: [Outreachy kernel] Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-05 Thread Julia Lawall
On Mon, 5 Mar 2018, Arushi Singhal wrote: > > > On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter > wrote: > On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > > Replace printk having a log level with the appropriate > > net_*macro_ratelimited. > > It's bette

Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-05 Thread Dan Carpenter
On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > Indentation is also changed, to fix the checkpatch issue if line is not > exce

Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Greg KH
On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > Indentation is also changed, to fix the checkpatch issue if line is not > exce

[PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue if line is not exceding 80 characters. Signed-off-by: Arushi Singhal --- .../rtl8192u/ieee