Re: [PATCH] staging: lustre: avoid going through unlock/lock overhead

2017-09-07 Thread Cihangir Akturk
On Thu, Sep 07, 2017 at 02:33:49PM +0200, Greg KH wrote: > On Thu, Sep 07, 2017 at 01:57:42PM +0300, Cihangir Akturk wrote: > > Unlocking a spin lock and then immediately locking without doing > > anything useful in between buys us nothing, except wasting CPU cycles. > > Not always, it can be a "g

Re: [PATCH] staging: lustre: avoid going through unlock/lock overhead

2017-09-07 Thread Greg KH
On Thu, Sep 07, 2017 at 01:57:42PM +0300, Cihangir Akturk wrote: > Unlocking a spin lock and then immediately locking without doing > anything useful in between buys us nothing, except wasting CPU cycles. Not always, it can be a "gate" for other users of the lock. Are you sure that is not what is

[PATCH] staging: lustre: avoid going through unlock/lock overhead

2017-09-07 Thread Cihangir Akturk
Unlocking a spin lock and then immediately locking without doing anything useful in between buys us nothing, except wasting CPU cycles. Also code size gets smaller. Before: text data bssdechex filename 70415 2356 4108 76879 12c4f drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd