Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-06 Thread Dilger, Andreas
On 2014/12/05, 3:41 PM, Tristan Lelong tris...@lelong.xyz wrote: On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote: On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: static ssize_t -fld_proc_hash_seq_write(struct file *file, const char *buffer, -

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-06 Thread Tristan Lelong
Andreas, On Sat, Dec 06, 2014 at 05:05:14PM +, Dilger, Andreas wrote: On 2014/12/05, 3:41 PM, Tristan Lelong tris...@lelong.xyz wrote: Sorry, but I don't see where you get 80 from? fh_name is declared as a const char *, and initialized in the declaration of fld_hash[]. I'd thought

[PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char *noident This is done by adding the missing __user attribute on userland pointers inside the LPROC_SEQ_FOPS-like macros: -

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Joe Perches
On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote: On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: [] diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c []

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Joe Perches
On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char *noident [] diff --git

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Greg KH
On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char *noident This is done by adding the missing __user attribute

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 12:44:07AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote: On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: [] diff --git

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote: On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: static ssize_t -fld_proc_hash_seq_write(struct file *file, const char *buffer, - size_t count, loff_t *off) +fld_proc_hash_seq_write(struct file