[PATCH] staging: lustre: Fix sparse warnings for undeclared symbols

2014-06-16 Thread Scott Weir
This patch fixes the sparse warnings in drivers/staging/lustre/lustre/ptlrpc/sec_lproc.c: sec_lproc.c:58:6: warning: symbol 'sec_flags2str' was not declared. Should it be static? Signed-off-by: Scott Weir --- drivers/staging/lustre/lustre/ptlrpc/sec_lproc.c | 2 +- 1 file changed, 1 insertion(

[PATCH] staging: lustre: fix sparse warnings for undeclared symbols

2014-06-02 Thread John Church
This patch fixes the following sparse warnings for drivers/staging/lustre/lnet/lnet/router.c: router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared. Should it be static? router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared. Should it be static? Signed-of

Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols

2014-06-02 Thread John Church
On Mon, Jun 02, 2014 at 03:19:18PM +0300, Dan Carpenter wrote: > > Why not just make them static? They don't seem to be used outside of > that file. What am I missing? > Given a 50/50 choice I based my decision on the surrounding functions which were mostly defined in the header file. I shou

Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols

2014-06-02 Thread Dan Carpenter
On Mon, Jun 02, 2014 at 01:03:48PM +0100, John Church wrote: > This patch fixes the following sparse warnings for > drivers/staging/lustre/lnet/lnet/router.c: > > router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared. > Should it be static? > router.c:277:1: warning: symbol 'l

[PATCH] staging: lustre: fix sparse warnings for undeclared symbols

2014-06-02 Thread John Church
This patch fixes the following sparse warnings for drivers/staging/lustre/lnet/lnet/router.c: router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared. Should it be static? router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared. Should it be static? Signed-of