Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function

2015-05-03 Thread Drokin, Oleg
On May 3, 2015, at 1:53 AM, Julia Lawall wrote: On Sat, 2 May 2015, Drokin, Oleg wrote: On May 2, 2015, at 5:16 PM, Julia Lawall wrote: Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a function, obd_cpt_alloc. Signed-off-by: Julia Lawall julia.law...@lip6.fr

[PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function

2015-05-02 Thread Julia Lawall
Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a function, obd_cpt_alloc. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- Some questions: Is the name OK? Is the NULL test needed? If not, should the call to kzalloc_node with the call to cfs_cpt_spread_node just be

Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function

2015-05-02 Thread Drokin, Oleg
On May 2, 2015, at 5:16 PM, Julia Lawall wrote: Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a function, obd_cpt_alloc. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- Some questions: Is the name OK? Is the NULL test needed? If not, should the call to

Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function

2015-05-02 Thread Dan Carpenter
On Sat, May 02, 2015 at 11:16:48PM +0200, Julia Lawall wrote: Some questions: Is the name OK? Is the NULL test needed? If not, should the call to kzalloc_node with the call to cfs_cpt_spread_node just be inlined into the call sites? drivers/staging/lustre/lustre/include/obd_support.h |