Re: [PATCH] staging: lustre: silence sparse warnings

2015-05-27 Thread Julia Lawall
Maybe the explanation should more like "Make functions that are not used in other files static", rather than just silencing a tool. julia On Wed, 27 May 2015, Marcus Folkesson wrote: > Warnings reported by sparse: > drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol > 'ptlrpc_p

[PATCH] staging: lustre: silence sparse warnings

2015-05-27 Thread Marcus Folkesson
Warnings reported by sparse: drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol 'ptlrpc_ping' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static? drivers/stagi