Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style

2021-05-04 Thread Deepak R Varma
On Fri, Apr 30, 2021 at 10:48:12PM +0530, Deepak R Varma wrote: > On Fri, Apr 30, 2021 at 08:12:41PM +0300, Sakari Ailus wrote: > > Hi Deepak, > > > > On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote: > > > On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote: > > > > Hi Deep

Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style

2021-04-30 Thread Deepak R Varma
On Fri, Apr 30, 2021 at 08:12:41PM +0300, Sakari Ailus wrote: > Hi Deepak, > > On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote: > > On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote: > > > Hi Deepak, > > > > > > If you're touching all these lines, I might do a little mor

Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style

2021-04-30 Thread Sakari Ailus
Hi Deepak, On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote: > On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote: > > Hi Deepak, > > > > If you're touching all these lines, I might do a little more. Please see > > the comments below. > > > Hello Sakari, > I can definitel

Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style

2021-04-30 Thread Deepak R Varma
On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote: > Hi Deepak, > > If you're touching all these lines, I might do a little more. Please see > the comments below. > Hello Sakari, I can definitely include other changes, but then it will be many different types of changes into a single p

Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style

2021-04-30 Thread Sakari Ailus
Hi Deepak, If you're touching all these lines, I might do a little more. Please see the comments below. On Fri, Apr 30, 2021 at 09:10:12PM +0530, Deepak R Varma wrote: > Misplaced braces makes it difficult to follow the code easily. This also > goes against the code style guidelines. This resolve

[PATCH] staging: media: atomisp: pci: reposition braces as per coding style

2021-04-30 Thread Deepak R Varma
Misplaced braces makes it difficult to follow the code easily. This also goes against the code style guidelines. This resolved following checkpatch complaints: ERROR: open brace '{' following function definitions go on the next line ERROR: that open brace { should be on the previous line Signed-o