Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-26 Thread Joe Perches
On Tue, 2014-11-25 at 21:14 +, Luis de Bethencourt wrote: On Tue, Nov 25, 2014 at 01:00:07PM -0800, Joe Perches wrote: In the future, you might consider being more comprehensive with your patches. Wasn't sure about the scope of the style fixing patches. I've been reading Kernel

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-26 Thread Joe Perches
On Wed, 2014-11-26 at 15:42 +, Luis de Bethencourt wrote: On 26 November 2014 at 01:49, Joe Perches j...@perches.com wrote: [] There is a script I posted a while back that groups various checkpatch types together and makes it a bit easier to do cleanup style patches.

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-26 Thread Luis de Bethencourt
On Wed, Nov 26, 2014 at 08:05:55AM -0800, Joe Perches wrote: On Wed, 2014-11-26 at 15:42 +, Luis de Bethencourt wrote: On 26 November 2014 at 01:49, Joe Perches j...@perches.com wrote: [] There is a script I posted a while back that groups various checkpatch types together and

[PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle recommends not splitting quotes strings across lines because it breaks the ability to grep for the string. Fixing these. WARNING: quoted string split across lines Signed-off-by: Luis de

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Joe Perches
On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle recommends not splitting quotes strings across lines because it breaks the ability to grep for the string. Fixing these. [] diff

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote: On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle recommends not splitting quotes strings across lines because it

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
On Tue, Nov 25, 2014 at 01:00:07PM -0800, Joe Perches wrote: On Tue, 2014-11-25 at 20:40 +, Luis de Bethencourt wrote: On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote: On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: checkpatch makes an exception to the

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Joe Perches
On Tue, 2014-11-25 at 20:40 +, Luis de Bethencourt wrote: On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote: On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle