Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Greg KH
On Fri, Aug 25, 2017 at 06:36:18PM +0300, Alex Briskin wrote: > 1. Remove redundant functions. > 2. Remove potentially missleading return code (-EIO). > 3. Add module_driver driver registration macro. > * Will also remove pr_info messages. If you have a list of things your patch does, that's a

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Andrey Shvetsov
Alex, On Fri, Aug 25, 2017 at 06:26:03PM +0300, Alex Briskin wrote: > Hi Andy, > I'm not sure what to make from your comment. I meant instead of module_driver(hdm_usb, usb_register, usb_deregister); use module_usb_driver(hdm_usb); since $ grep def.*module_usb_driver

[PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Alex Briskin
1. Remove redundant functions. 2. Remove potentially missleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Alex Briskin
Hi Andy, I'm not sure what to make from your comment. I stand by my patch. According to device.h module_driver is a variadic macro requiring at least 3 parameters. Please see below quote: /** * module_driver() - Helper macro for drivers that don't do anything * special in module init/exit.

Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Andrey Shvetsov
On Fri, Aug 25, 2017 at 12:47:33PM +0300, Alex Briskin wrote: > 1. Remove redundant functions. > 2. Remove potentially misleading return code (-EIO). > 3. Add module_driver driver registration macro. > * Will also remove pr_info messages. > > Signed-off-by: Alex Briskin >

[PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Alex Briskin
1. Remove redundant functions. 2. Remove potentially misleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file

[PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

2017-08-25 Thread Alex Briskin
1. Remove redundant functions. 2. Remove potentially missleading return code (-EIO). 3. Add module_driver driver registration macro. * Will also remove pr_info messages. Signed-off-by: Alex Briskin --- drivers/staging/most/hdm-usb/hdm_usb.c | 20 +--- 1 file