Re: [PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread Marcus Wolf
Once again in plain text, only - sorry for frogetting to set the switch in my mailtool Hi Dan, Hi Walter, thank you for your investigation. rf69_get_modulation, rf69_get_lna_gain, rf69_set_lna_gain: Seems like I messed up a few things :-/ In the beginning, the defines were left-bound "r

Re: [PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread Dan Carpenter
Actually, please drop this patch. I looked at this one the same as I did the other one, but I didn't look closely enough. It's the same situation where we have two bugs that probably cancel each other out somewhat. It maybe needs to be fixed by someone who can test the code. In rf69_set_lna_gai

Re: [PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread walter harms
Am 19.07.2017 11:51, schrieb Dan Carpenter: > We had intended to do the mask first and then the shift. Shift has > higher precedence so we need to add parenthesis. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/pi433/rf69

[PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread Dan Carpenter
We had intended to do the mask first and then the shift. Shift has higher precedence so we need to add parenthesis. Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e391ce777bc7..508944