Re: [PATCH] staging: pi433: fix missing break in switch statement.

2017-11-10 Thread Marcus Wolf
Hi Colin, thanks for clarification. Should I switch to that repo for further work, too? If so, can anybody provide me the link? Do I need Gregs staging any longer, or is it kind of dead for devel on pi433 driver? Thank you so much! Marcus Am 10.11.2017 um 18:04 schrieb Colin Ian King: > On

Re: [PATCH] staging: pi433: fix missing break in switch statement.

2017-11-10 Thread Colin Ian King
On 10/11/17 16:49, Marcus Wolf wrote: > Hi all! > > Tryed to cross check... > > Don't get it, sorry. > > On my private version control (my SVN), where I initially developed the > driver the break isn't missing. > Same with my git copy of Gregs staging tree. Break is there... > > Who removed

Re: [PATCH] staging: pi433: fix missing break in switch statement.

2017-11-10 Thread Marcus Wolf
Hi all! Tryed to cross check... Don't get it, sorry. On my private version control (my SVN), where I initially developed the driver the break isn't missing. Same with my git copy of Gregs staging tree. Break is there... Who removed it, why is it missing in Colins copy? Am I working on a

Re: [PATCH] staging: pi433: fix missing break in switch statement.

2017-11-09 Thread Dan Carpenter
On Thu, Nov 09, 2017 at 05:19:55PM +, Colin King wrote: > From: Colin Ian King > > The PI433_IOC_WR_RX_CFG case is missing a break and will fall through > to the default case and errorenously return -EINVAL. Fix this by > adding in missing break. > Could you fix

Re: [PATCH] staging: pi433: fix missing break in switch statement.

2017-11-09 Thread Al Viro
On Thu, Nov 09, 2017 at 05:19:55PM +, Colin King wrote: > From: Colin Ian King > > The PI433_IOC_WR_RX_CFG case is missing a break and will fall through > to the default case and errorenously return -EINVAL. Fix this by > adding in missing break. Folded and

[PATCH] staging: pi433: fix missing break in switch statement.

2017-11-09 Thread Colin King
From: Colin Ian King The PI433_IOC_WR_RX_CFG case is missing a break and will fall through to the default case and errorenously return -EINVAL. Fix this by adding in missing break. Detected by CoverityScan, CID#1461286 ("Missing break in switch") Fixes: f81f0b5c9a30