Re: [PATCH] staging: qlge: fix build breakage with dumping enabled

2020-08-25 Thread Benjamin Poirier
On 2020-08-25 19:16 +0800, Coiby Xu wrote: [...] > > > @@ -1630,7 +1630,7 @@ void ql_dump_wqicb(struct wqicb *wqicb) > > > (unsigned long long)le64_to_cpu(wqicb->cnsmr_idx_addr)); > > > } > > > > > > -void ql_dump_tx_ring(struct tx_ring *tx_ring) > > > +void ql_dump_tx_ring(struct

Re: [PATCH] staging: qlge: fix build breakage with dumping enabled

2020-08-25 Thread Coiby Xu
On Fri, Aug 21, 2020 at 05:31:59PM +0900, Benjamin Poirier wrote: On 2020-08-21 15:03 +0800, Coiby Xu wrote: This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage with dumping enabled, i.e., $ QL_ALL_DUMP=1 QL_OB_DUMP=1

Re: [PATCH] staging: qlge: fix build breakage with dumping enabled

2020-08-21 Thread Benjamin Poirier
On 2020-08-21 15:03 +0800, Coiby Xu wrote: > This fixes commit 0107635e15ac > ("staging: qlge: replace pr_err with netdev_err") which introduced an > build breakage with dumping enabled, i.e., > > $ QL_ALL_DUMP=1 QL_OB_DUMP=1 QL_CB_DUMP=1 QL_REG_DUMP=1 \ > QL_IB_DUMP=1 QL_DEV_DUMP=1

[PATCH] staging: qlge: fix build breakage with dumping enabled

2020-08-21 Thread Coiby Xu
This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage with dumping enabled, i.e., $ QL_ALL_DUMP=1 QL_OB_DUMP=1 QL_CB_DUMP=1 QL_REG_DUMP=1 \ QL_IB_DUMP=1 QL_DEV_DUMP=1 make M=drivers/staging/qlge Fixes: 0107635e15ac ("taging: