Re: [PATCH] staging: rtl8188eu: fix possible null dereference

2019-09-26 Thread Connor Kuehl
On 9/25/19 5:05 PM, Larry Finger wrote: This change is a good one, but why not get the same fix at line 779? Ah yes! Thanks for pointing that out. I missed that. I will send a V2 shortly. Thank you, Connor Larry ___ devel mailing list

Re: [PATCH] staging: rtl8188eu: fix possible null dereference

2019-09-25 Thread Larry Finger
On 9/25/19 4:32 PM, Connor Kuehl wrote: Inside a nested 'else' block at the beginning of this function is a call that assigns 'psta' to the return value of 'rtw_get_stainfo()'. If 'rtw_get_stainfo()' returns NULL and the flow of control reaches the 'else if' where 'psta' is dereferenced, then we

[PATCH] staging: rtl8188eu: fix possible null dereference

2019-09-25 Thread Connor Kuehl
Inside a nested 'else' block at the beginning of this function is a call that assigns 'psta' to the return value of 'rtw_get_stainfo()'. If 'rtw_get_stainfo()' returns NULL and the flow of control reaches the 'else if' where 'psta' is dereferenced, then we will dereference a NULL pointer. Fix

[PATCH] staging: rtl8188eu: fix possible NULL dereference

2015-08-14 Thread Sudip Mukherjee
dm_odm was being checked for NULL after dereferencing it. Lets check for NULL first before derefenrencing it. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git