Re: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread
On Sat, Jul 25, 2020 at 03:34:34PM +0200, Greg KH wrote: > On Sat, Jul 25, 2020 at 02:28:06PM +0100, John Oldman wrote: > > clear below issues reported by checkpatch.pl: > > > > CHECK: Using comparison to true is error prone > > Your subject line is very odd :( Thanks, I should read all before

Re: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread Greg KH
On Sat, Jul 25, 2020 at 02:28:06PM +0100, John Oldman wrote: > clear below issues reported by checkpatch.pl: > > CHECK: Using comparison to true is error prone Your subject line is very odd :( > Signed-off-by: John Oldman > --- > v1: Initial attempt. > v2: Removed unneccessary parentheses

[PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- v1: Initial attempt. v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable' Also considered clearing 'CHECK: Logical continuations should be on the

Re: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-11 Thread
Hi Gustavo Thanks for the feedback. I'll re-submit the patch. Many thanks john On Fri, Jul 10, 2020 at 03:44:53PM -0500, Gustavo A. R. Silva wrote: > > > On 7/10/20 15:16, John Oldman wrote: > > clear below issues reported by checkpatch.pl: > > > > CHECK: Using comparison to true is error

Re: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-10 Thread Gustavo A. R. Silva
On 7/10/20 15:16, John Oldman wrote: > clear below issues reported by checkpatch.pl: > > CHECK: Using comparison to true is error prone > > Signed-off-by: John Oldman > --- > drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

[PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-10 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c