Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

2017-08-25 Thread Alexander Duyck
Fri, Aug 25, 2017 at 7:16 AM, Andrew Lunn wrote: > On Fri, Aug 25, 2017 at 08:47:00AM -0500, Larry Finger wrote: >> On 08/24/2017 08:54 PM, Andrew Lunn wrote: >> >netdev frowns upon debugfs. You should try to keep this altogether, >> >making it easy to throw away before the driver

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

2017-08-25 Thread Andrew Lunn
On Fri, Aug 25, 2017 at 08:47:00AM -0500, Larry Finger wrote: > On 08/24/2017 08:54 PM, Andrew Lunn wrote: > >netdev frowns upon debugfs. You should try to keep this altogether, > >making it easy to throw away before the driver is moved out of > >staging. > > > >You might want to look at ethtool

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

2017-08-25 Thread Larry Finger
On 08/24/2017 08:54 PM, Andrew Lunn wrote: netdev frowns upon debugfs. You should try to keep this altogether, making it easy to throw away before the driver is moved out of staging. You might want to look at ethtool -d. That will be accepted. Andrew, What is the problem with debugfs?

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

2017-08-24 Thread Andrew Lunn
On Thu, Aug 24, 2017 at 04:28:08PM -0500, Larry Finger wrote: > The changes in this commit are also being sent to the main rtlwifi > drivers in wireless-next; however, these changes will also be useful for > any debugging of r8822be before it gets moved into the main tree. > > Use debugfs to dump

[PATCH] staging: rtlwifi: Improve debugging by using debugfs

2017-08-24 Thread Larry Finger
The changes in this commit are also being sent to the main rtlwifi drivers in wireless-next; however, these changes will also be useful for any debugging of r8822be before it gets moved into the main tree. Use debugfs to dump register and btcoex status, and also write registers and h2c. We