Re: [PATCH] staging: rts5208: remove always true comparison

2015-05-25 Thread Dan Carpenter
On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote: On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote: On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote: the if comparison is always true as anything bitwise and-ing with 0x1E can never be equal to

Re: [PATCH] staging: rts5208: remove always true comparison

2015-05-25 Thread Sudip Mukherjee
On Mon, May 25, 2015 at 07:22:40PM +0300, Dan Carpenter wrote: On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote: On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote: On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote: the if comparison is always true

Re: [PATCH] staging: rts5208: remove always true comparison

2015-05-15 Thread Sudip Mukherjee
On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote: On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote: the if comparison is always true as anything bitwise and-ing with 0x1E can never be equal to 0x03. Fixes bugzilla:

[PATCH] staging: rts5208: remove always true comparison

2015-05-14 Thread Sudip Mukherjee
the if comparison is always true as anything bitwise and-ing with 0x1E can never be equal to 0x03. Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881 Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Sudip Mukherjee su...@vectorindia.org ---

Re: [PATCH] staging: rts5208: remove always true comparison

2015-05-14 Thread Dan Carpenter
On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote: the if comparison is always true as anything bitwise and-ing with 0x1E can never be equal to 0x03. Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881 It doesn't fix anything though, it just silences the