Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Niklas Svensson
On 11/08/2014 08:56 PM, Jason Cooper wrote: On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Jason Cooper
On Sun, Nov 09, 2014 at 07:51:36PM +0100, Niklas Svensson wrote: On 11/08/2014 08:56 PM, Jason Cooper wrote: On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be

[PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-08 Thread Niklas Svensson
drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:100:5: warning: symbol

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-08 Thread Jason Cooper
On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be