Re: [PATCH] staging: sm750fb: Fix lock context error

2016-10-24 Thread br . shurik
On Monday, 24 October 2016 13:41:39 IDT Dan Carpenter wrote: > evaluation Hi Dan, Thanks you for your feedback, it kind of felt like workaround. However, it seems to me like bad design decision took place where locking/ unlocking is dependent on unprotected variable. >From what I could understand

Re: [PATCH] staging: sm750fb: Fix lock context error

2016-10-24 Thread Dan Carpenter
On Sun, Oct 23, 2016 at 03:37:57PM +0300, Alex Briskin wrote: > Sparse error fix - different lock contexts for basic block. > Acquirement and release of spin lock was dependent on two separate > unprotected variable evaluations. Instead the condition evaluation result > is stored in a local

[PATCH] staging: sm750fb: Fix lock context error

2016-10-23 Thread Alex Briskin
Sparse error fix - different lock contexts for basic block. Acquirement and release of spin lock was dependent on two separate unprotected variable evaluations. Instead the condition evaluation result is stored in a local boolean variable to make sure that the same context that called the