Re: [PATCH] staging: sm750fb: move common locking code to a macro

2017-06-21 Thread Greg KH
On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote: > The locking and unlocking code used by copy routines is common, so > moved it to a macro. Ick, no, never "hide" locks like this, that's not good at all. We want to see the locks in the code where it happens, otherwise it is not

Re: [PATCH] staging: sm750fb: move common locking code to a macro

2017-06-21 Thread Dan Carpenter
On Wed, Jun 21, 2017 at 10:59:01AM +0200, Dhananjay Balan wrote: > Tue, 2017-06-20, 23:05 +0300-യ്ക്ക, Dan Carpenter എഴുതിയിരിക്കുന്നു: > > On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote: > > > The locking and unlocking code used by copy routines is common, so > > > moved it to a

Re: [PATCH] staging: sm750fb: move common locking code to a macro

2017-06-21 Thread Dhananjay Balan
Tue, 2017-06-20, 23:05 +0300-യ്ക്ക, Dan Carpenter എഴുതിയിരിക്കുന്നു: > On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote: > > The locking and unlocking code used by copy routines is common, so > > moved it to a macro. > > > > Signed-off-by: Dhananjay Balan > > --- >

Re: [PATCH] staging: sm750fb: move common locking code to a macro

2017-06-20 Thread Dan Carpenter
On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote: > The locking and unlocking code used by copy routines is common, so > moved it to a macro. > > Signed-off-by: Dhananjay Balan > --- > drivers/staging/sm750fb/sm750.c | 81 >

[PATCH] staging: sm750fb: move common locking code to a macro

2017-06-20 Thread Dhananjay Balan
The locking and unlocking code used by copy routines is common, so moved it to a macro. Signed-off-by: Dhananjay Balan --- drivers/staging/sm750fb/sm750.c | 81 - 1 file changed, 31 insertions(+), 50 deletions(-) diff --git