Re: [PATCH] staging: speakup: fix warning for static declaration

On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote: > Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote: > > Thanks for this :) Could you also move the function higher in the same > > file - above line 139 where all static functions are defined? > > I'd say no need for this.

Re: [PATCH] staging: speakup: fix warning for static declaration

Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote: > Thanks for this :) Could you also move the function higher in the same > file - above line 139 where all static functions are defined? I'd say no need for this. spk_serial_in is just above. Moving functions just for the sake of static

Re: [PATCH] staging: speakup: fix warning for static declaration

Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote: > Fix the following sparse warning: > symbol 'spk_serial_out' was not declared. Should it be static? > > Signed-off-by: Gustavo A. R. Silva Yes, indeed. Reviewed-by: Samuel Thibault

Re: [PATCH] staging: speakup: fix warning for static declaration

Hi Gustavo, On Mon, Mar 27, 2017 at 01:37:29AM -0500, Gustavo A. R. Silva wrote: > Fix the following sparse warning: > symbol 'spk_serial_out' was not declared. Should it be static? > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/speakup/serialio.c | 2

[PATCH] staging: speakup: fix warning for static declaration

Fix the following sparse warning: symbol 'spk_serial_out' was not declared. Should it be static? Signed-off-by: Gustavo A. R. Silva --- drivers/staging/speakup/serialio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git