Probably once you start writing a patch you will figure it out. :)
keymap_store() is a crap function. We have the cp1 pointer that points
to the end of two back to back 3 char arrays. The name cp1 is because
it is the second copy of the cp buffer which is a copy of the buf
buffer. Since it is
On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote:
On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
Nope. Your patch is totally wrong (buggy). Please be more careful in
the future.
On Wed, Jun 24, 2015 at 12:19:27PM +0200, Luis de Bethencourt wrote:
On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote:
On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
Nope. Your patch is
Use the newer and nicer kstrtoint(), because simple_strtoul() is now obsolete.
Signed-off-by: Luis de Bethencourt l...@debethencourt.com
---
drivers/staging/speakup/varhandlers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/varhandlers.c
On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
Nope. Your patch is totally wrong (buggy). Please be more careful in
the future.
regards,
dan carpenter
I saw other commits replace the obsolete
Nope. Your patch is totally wrong (buggy). Please be more careful in
the future.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
Nope. Your patch is totally wrong (buggy). Please be more careful in
the future.
regards,
dan carpenter
I saw other commits replace the obsolete simple_strtoul() this way and the
documentation makes it look like it is a 1 to
