[PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-08-13 Thread Arnd Bergmann
The TODO item named "make spi and sdio components coexist in one build" was apparently addressed a long time ago, but never removed from the TODO file. However, the new patch that tries to address it actually makes it worse again by duplicating the common parts of the driver into two separate modul

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-09-10 Thread Ajay Singh
Hi Greg, On Tue, 14 Aug 2018 10:43:35 +0200 gregkh wrote: > On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh > > wrote: > > > > > > Hi Arnd, > > > > > > On Mon, 13 Aug 2018 23:20:33 +0200 > > > Arnd Bergmann wrote: > > > > > > > The

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-09-11 Thread gregkh
On Mon, Sep 10, 2018 at 04:08:36PM +0530, Ajay Singh wrote: > Hi Greg, > > On Tue, 14 Aug 2018 10:43:35 +0200 > gregkh wrote: > > > On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > > > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh > > > wrote: > > > > > > > > Hi Arnd, > > > > > > >

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-09-11 Thread Ajay Singh
On Tue, 11 Sep 2018 10:21:10 +0200 gregkh wrote: > On Mon, Sep 10, 2018 at 04:08:36PM +0530, Ajay Singh wrote: > > Hi Greg, > > > > On Tue, 14 Aug 2018 10:43:35 +0200 > > gregkh wrote: > > > > > On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > > > > On Tue, Aug 14, 2018 at

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-08-13 Thread Ajay Singh
Hi Arnd, On Mon, 13 Aug 2018 23:20:33 +0200 Arnd Bergmann wrote: > The TODO item named "make spi and sdio components coexist in one > build" was apparently addressed a long time ago, but never removed > from the TODO file. However, the new patch that tries to address it > actually makes it worse

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-08-14 Thread Arnd Bergmann
On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh wrote: > > Hi Arnd, > > On Mon, 13 Aug 2018 23:20:33 +0200 > Arnd Bergmann wrote: > > > The TODO item named "make spi and sdio components coexist in one > > build" was apparently addressed a long time ago, but never removed > > from the TODO file. Howeve

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-08-14 Thread gregkh
On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh wrote: > > > > Hi Arnd, > > > > On Mon, 13 Aug 2018 23:20:33 +0200 > > Arnd Bergmann wrote: > > > > > The TODO item named "make spi and sdio components coexist in one > > > build" was appar